Conversation
PWagner1
commented
Mar 9, 2025
PWagner1
commented
- Implemented [Feature Request]: Implement a way of getting a way to show keyboard shortcuts #2134 + some theming stuff
Catchup 09/03/2025
|
Can you please provide an overview of how this works on the discord channel where we discuss the theming changes. |
| // Extract Fonts | ||
| XmlNodeList fontNodes = root.SelectNodes("Resources/Fonts/Font"); | ||
| foreach (XmlNode fontNode in fontNodes) | ||
| XmlNodeList? fontNodes = root.SelectNodes("Resources/Fonts/Font"); |
There was a problem hiding this comment.
Why is this a Base64Coded string. Font has a toString and from string conversion
There was a problem hiding this comment.
@Smurf-IV & @PWagner1 & @Ahmed-Abdelhameed
With all respect for the work already put in.
Also like this PR and especially these changes should be done through dedicated PRs and not mixed in with other work, so we can keep track of what has happened and be able to do a roll-back if applicable.
Earlier announced tests to see if we can fully export the built-in themes (including images) still do not have been reported on e.g. there is no status on that and no knowledge to take forward in the decision making process. All changes need to be compatible throughout the components affected avoiding patchwork.
I stay at the point to first complete the discussion, possible testing, and planning before coding starts.
There was a problem hiding this comment.
Also I'm not sure if this is the correct approach.
The earlier understanding or idea was to export the built-in themes to the KCusotmpalettebase format which already can serialize to and from XML.
Probably this serialization in KCPB needs extending and is still up for discussion.
There was a problem hiding this comment.
The KryptonThemeLoader will export the built-in themes to *.kthemes in its current state. But I can't find a way to bundle Krypton.Base.Themes.dll into the NuGet package. If either of you have the time, please could you investigate a way of doing this, while I clean the PR's up?
Note: I'll set this as a draft
There was a problem hiding this comment.
Also I'm not sure if this is the correct approach.
The earlier understanding or idea was to export the built-in themes to the KCusotmpalettebase format which already can serialize to and from XML.
Probably this serialization in KCPB needs extending and is still up for discussion.
So, the new *.ktheme files are essentially the existing XML files, but with extra metadata to accommodate theme name, images & fonts
There was a problem hiding this comment.
This is what I'm saying earlier that the discussion, etc. is not complete and this is floating in an undetermined direction.
…o-show-keyboard-shortcuts' into catchup-17-03-2025
Catchup 17/03/2025
…o-show-keyboard-shortcuts' into alpha-2153
Catchup 21/03/2025
|
Conflicts |
PWagner1
deleted the
2134-feature-request-implement-a-way-of-getting-a-way-to-show-keyboard-shortcuts
branch
3 participants
